Can't view next and previous sentence at the end of a Quote. "」"

Support & Feedback Forum
1

Lingq parsed Quotes in a way that the end of a Quote “」” is most of the time a single “sentence”. But when i reach this part in sentence-mode i’m unable to move to the next sentence or previous sentence.

I need to move back to the lessons view. Then, because Lingq doesn’t remember where i was in the sentence view, do i need to move forward to the sentence where it stuck. click on the next word and go back into sentence mode.

This extremely troublesome if the book has a lot of those direct Quotes.
Language: japanese

1 Like
2

Thanks for reporting! We will look into it and have it fixed.

3

i guess this hasn’t been fixed yet? or if it had, then i’m experiencing a new version of this bug, with the same exact symptoms. any workarounds?

1 Like
4

Thanks, I’ll check what is the status here.

5

See report of same bug:

1 Like
6

zoran:

Does your team know about regression testing or does it just not bother?

Regression testing is re-running functional and non-functional tests to ensure that previously developed and tested software still performs as expected after a change.

Regression testing - Wikipedia

1 Like
7

if it helps…

Was getting this error in the console (when clicking next or previous buttons in sentence mode):

helpers.ts:138 Uncaught TypeError: Cannot read properties of undefined (reading 'get')
    at t.resetSentencePhrases (main-4fff84bdaff79a332b4a.js:2:6165916)
    at t.value (main-4fff84bdaff79a332b4a.js:2:6175086)
    at main-4fff84bdaff79a332b4a.js:2:5891326
    at sentryWrapped (helpers.ts:116:17)

so, as a workaround, i made the following override to that script on my browser… slap-dash, but fixed it for me:

N(u, "resetSentencePhrases", (function(e) {
  var t = u.sentences.get(e - 1)
    , a = u
    , n = a.lineHeight
    , r = a.fontSize
    , l = a.showSpaces
    , i = a.theme
    , o = a.showTranslitStatusAll
    , s = a.showRubyScript
    , c = a.showTranslation
    , d = u.view.pageStartIndex
    , f = t.get("tokens").find((function(e) {
      return e.get("wordId")
  }
  ))?.get("index") < d // OVERRIDE: added ? before .get() to avert undefined error
1 Like
8

Thanks, our testers are looking into this.

9

@bemorekindmyfriend @judayjude Can you guys please provide the URL to one of the Japanese lessons with the mentioned issue? We were able to reproduce the issue with French and are working on it, but so far, we couldn’t reproduce it in Japanese. Thanks.

10

Here’s an example, an epub i imported:

https://www.lingq.com/en/learn/ja/web/reader/39587610

sentence # 22

Here’s what appears to cause it:

  1. book is imported, parser encounters a quoted line ending with punctuation + end quote, e.g. ？」
  2. parser splits this quoted line into 2 sentences, such that everything before the end quote is the first sentence, and the end quote by itself is the second sentence
  3. you end up with that second sentence having no actual words in it. just punctuation
  4. load this book in sentence mode, on a desktop browser
  5. go to the sentence right before the problematic wordless sentence
  6. try to advance to that next sentence: a javascript error occurs, and paging forward or backward is broken until the browser is refreshed.

Note: this seems to be language independent, and only coincidentally related to quote marks due to the weird parsing/sentence splitting around end quotes described above. it can be reproduced simply by having a sentence with no word in it. such as just an ellipsis. i’ve tested that here, by adding a sentence with just an ellipsis to ths spanish book i imported (second sentence):

https://www.lingq.com/en/learn/es/web/reader/39206984
1 Like
11

Thanks, we will have it fixed.